Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-93: DHCP4v2 onelease plugin code for VRouter #139

Merged
merged 25 commits into from
Dec 30, 2024

Conversation

aleixrm
Copy link
Member

@aleixrm aleixrm commented Nov 20, 2024

PoC of the implementation of the DHCP4 feature of VRouter using coredhcp instead of Kea. You can check the README file included in this PR for more details.

For the moment, it's named DHCP4v2, and has replaced the original DHCP4 feature in the VRouter, excluding it from the packer packaging. We compile the go binary on the build process and only includes that binary in the packer appliance distribution.

Probably we want to automate the go tests execution on PRs through github actions.

Closes #93

@aleixrm aleixrm requested review from sk4zuzu and rsmontero December 2, 2024 16:14
@aleixrm aleixrm marked this pull request as ready for review December 2, 2024 16:29
@rsmontero rsmontero added type: feature A new feature planned for implementation category: virtual router Virtual Router appliance status: accepted The issue is valid and will be planned for fix or implementation labels Dec 3, 2024
@rsmontero rsmontero added this to the Release 6.10.2 milestone Dec 3, 2024
aleixrm and others added 23 commits December 30, 2024 09:56
Signed-off-by: Aleix Ramírez <[email protected]>
- Remove legacy DHCP4 with KEA
- Add coredhcp service
- Cleanup golang binaries to reduce image size
- Upgrade Alpine to 3.20
- Code cleanups
- Always run iptables service
- Refactor one-failover logic to fix regressions after Alpine update
- Improve one-failover performance
- Add "standby" command for keepalived
- Code cleanups
@sk4zuzu sk4zuzu force-pushed the f-93/dhcpcore-implementation branch from b8e4137 to fa18da9 Compare December 30, 2024 09:05
Copy link
Contributor

@sk4zuzu sk4zuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsmontero rsmontero merged commit 1d70e8c into master Dec 30, 2024
1 check passed
@rsmontero rsmontero deleted the f-93/dhcpcore-implementation branch December 30, 2024 10:54
@rsmontero rsmontero modified the milestones: Release 6.10.2, Release 6.10.0-3 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: virtual router Virtual Router appliance status: accepted The issue is valid and will be planned for fix or implementation type: feature A new feature planned for implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update VRouter to Alpine 3.19 + Move kea DHCP4 hook to one-apps
4 participants