-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f-93: DHCP4v2 onelease plugin code for VRouter #139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsmontero
added
type: feature
A new feature planned for implementation
category: virtual router
Virtual Router appliance
status: accepted
The issue is valid and will be planned for fix or implementation
labels
Dec 3, 2024
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Jaime <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Jaime <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Jaime <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Jaime <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Jaime <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
Signed-off-by: Jaime <[email protected]>
Signed-off-by: Jaime <[email protected]>
Signed-off-by: Aleix Ramírez <[email protected]>
- Remove legacy DHCP4 with KEA - Add coredhcp service - Cleanup golang binaries to reduce image size - Upgrade Alpine to 3.20 - Code cleanups
- Always run iptables service - Refactor one-failover logic to fix regressions after Alpine update - Improve one-failover performance - Add "standby" command for keepalived - Code cleanups
sk4zuzu
force-pushed
the
f-93/dhcpcore-implementation
branch
from
December 30, 2024 09:05
b8e4137
to
fa18da9
Compare
sk4zuzu
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: virtual router
Virtual Router appliance
status: accepted
The issue is valid and will be planned for fix or implementation
type: feature
A new feature planned for implementation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC of the implementation of the DHCP4 feature of VRouter using coredhcp instead of Kea. You can check the README file included in this PR for more details.
For the moment, it's named DHCP4v2, and has replaced the original DHCP4 feature in the VRouter, excluding it from the packer packaging. We compile the go binary on the build process and only includes that binary in the packer appliance distribution.
Probably we want to automate the go tests execution on PRs through github actions.
Closes #93